search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
49.96k stars 3.06k forks source link

Incorrect text display in the editor (nvidia 650M, 750M) #6853

Closed sfclub closed 2 months ago

sfclub commented 9 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

In Zed 0.119.20(7773c7d1ca36b595e2e385a5678b8b69c6a0c3d6)(intel mac) Incorrect text display in the editor. For details, see the attached video: [

https://github.com/zed-industries/zed/assets/7209477/45bee645-5dca-47d7-9ddb-266c08e1f940

](url)

Environment

MacOs Big Sur 11.7.10, MacBook Pro Retina, 15-inch, late 2013) Cpu intel I7 4 core, Memory 16Gb, Gpu Intel Iris Pro 1536Mb

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

osiewicz commented 9 months ago

Hi, thanks for reporting this issue. Does this reproduce for you reliably on some particular file/project? If so, could you share that? It would also be great to see if there's anything in your logs.

sfclub commented 9 months ago

Hi, yes, the problem is constant, because of this I can't use your wonderful editor on my laptop. How do I upload logs? Nothing changes on the latest versions.

sfclub commented 9 months ago

Zed.log

sfclub commented 9 months ago

https://github.com/zed-industries/zed/assets/7209477/d6081fc0-bf49-49a0-b34d-06ab208824c1

sfclub commented 9 months ago

I really want to use your great editor, but it doesn't work because of this bug:( What can be done to speed up the solution of this problem?

Akshat-Jain commented 9 months ago

I really want to use your great editor, but it doesn't work because of this bug:( What can be done to speed up the solution of this problem?

+1 :( I'm also facing the same issue on MacBook Pro (Mid 2012). My specs: Processor: 2.7 GHz Quad-Core Intel Core i7 Memory: 16 GB 1600 MHz DDR3 Graphics: NVIDIA GeForce GT 650M 1 GB + Intel HD Graphics 4000 1536 MB

jlabs commented 9 months ago

Came here to log I have the same issue - thinking the recent updates would have fixed the issue.

Specs are: MacOS 10.15.7 MacBook Pro (Retina, 15-inch, Early 2013) Processor: 2.7 GHz Quad-Core Intel Core i7 Memory: 16 GB 1600 MHz DDR3 Graphics: NVIDIA GeForce GT 650M 1 GB, Intel HD Graphics 4000 1536 MB

CurbaiCode commented 9 months ago

This is probably the same as #5062.

lhps commented 8 months ago

I'm suffering with the same bug

bennjjii commented 8 months ago

Same issue, old mac

sfclub commented 8 months ago

It seems to me that this does not apply to old macs, but to nvidia graphics cards. But since nvidia is only available in older mac models, this is why this problem pops up on older macs.

lhps commented 8 months ago

Please fix it asap, I am looking forward to use Zed without this problem, because it is really annoying.

sassrobi commented 8 months ago

Same issue for me. Late '13 MacBook Pro, OS: Big Sur (11.7.10), and yes it has a dedicated nvidia graphics card too.

I don't know if this is relevant, but IntelliJ IDEA also produces some similar glitches (not in the editor but on buttons and popups)

osiewicz commented 8 months ago

I don't know if this is relevant, but IntelliJ IDEA also produces some similar glitches (not in the editor but on buttons and popups)

Yeah, that's relevant; thanks for sharing =)

I wonder, do these glitches occur when you're only battery/connected? I wonder if power management could be at play anyhow.

sassrobi commented 7 months ago

Yes, I have rendering issues on battery and connected too. I have double-checked that the discrete GPU wasn't enabled. Even if I enforce to use the discrete GPU, or if I enforce to use the integrated GPU the result is the same.

sassrobi commented 7 months ago

I have created a video of the glitch. It's strange but now I have rendering issue in the sidebar and in the editor area only if I open the yaml file shown on the video. If I open a Rust file, there is no glitch neither in the editor nor in the sidebar!

As far as I remember last time (when I wrote my first comment) the Rust files was bad too. Perhaps something has changed, because I have installed the newest release of Zed (0.127.3) before testing.

https://github.com/zed-industries/zed/assets/3763226/ea7a42bc-cb97-4c8a-b0e2-bc9da463f15a

sassrobi commented 7 months ago

Update:

sfclub commented 7 months ago

it seems to me that the behavior has changed because of the bug fix https://github.com/zed-industries/zed/issues/8341

sfclub commented 7 months ago

Update:

  • There are some rendering issues in .rs files too, but much fewer
  • There are constant, reproducible glitches in .yml and Cargo.lock files
  • Even in .rs files, if i put a - or _ character in the filename, the glitches become more frequent
  • There is no "end of the file is hidden" issue anymore that can be seen in the video of the original issue (but it was with the previous version)

it does not depend on the type of files at all, the bug happens on different types of files. Depends on the nvidia card on board the computer

WayneBechstein commented 5 months ago

Same problems here on macOS Big Sur 11.7.10.

MacBook Pro (Retina, 15-inch, Mid 2014) Processor: 2.5 GHz Quad-Core Intel Core i7 Graphics: Intel Iris Pro 1536 MB

notpeter commented 4 months ago

Here is a list of the machine types which seem to be impacted:

I know these are old machines (all 10+ years old) but maybe we (Zed) should see if we can get our hands on one and see if we can reproduce the issue.

notpeter commented 4 months ago

I'm wondering whether this issue is being caused by the Nvidia card, the Intel card or by the dynamics switching between them. There is a third part tool gfxCardStatus which allows explicitly controlling this switching.

Could someone with an affected mac try that tool and report whether the graphics glitches occur in any/all of the following modes:

Labrium commented 4 months ago

Here is a list of the machine types which seem to be impacted:

As far as I know, iMacs don't use graphics switching, and I'm having the same problem with my setup:

notpeter commented 4 months ago

@Labrium Interesting. This definitely points the finger at the Nvidia side of things but the 650M/750M were designed to be operated in a switching graphics setup.

Looking at MacTracker and Intel Ark the 21.5inch Late 2013 shipped with three different processors:

Apple specs never mention the 4600 for that iMac, but I'm pretty sure it was still on-CPU. MacOS definitely shipped Intel HD Graphics 4600 compatible drivers (see: hackintosh forums), but maybe the driver/system preferences hid this switching option except on Macbooks with the better Iris Pro 5200 (instead of your HD 4600).

I dug a little deeper and there are some discussions that Metal2 didn't perform well on the Nvidia 750M and that in many cases the Iris 5200 was faster. Hopefully someone with that configuration can try switching integrated graphics only (disabling the nvidia) and see if that helps.

Anyways, thanks for sharing an additional data point. Very much appreciate it.

notpeter commented 4 months ago

A change went out in Zed Preview today (0.143.x) to force use of lower power Intel graphics over the discrete card when both are available. Only tested on newer Macbooks, but would love for someone to test this on their older Macbook to see if this fixes the visual bugs.

Akshat-Jain commented 4 months ago

@notpeter Hi! Thanks for the update! I tested it on my older Macbook Pro (specs posted in an earlier comment).

Zed Version: Zed Preview 0.143.2

The above version fixes the rendering issues for me, but it seems to have introduced significant latency when typing or scrolling. There's a noticeable delay in these actions, which wasn't happening before.

Appreciate your inputs on this. Please let me know if there's anything I can help with to enable you to take it further. Thanks!

notpeter commented 4 months ago

@Akshat-Jain Glad to hear it's no longer rendering gibberish and sorry to hear about the latency. There is some linux-related work which may improve performance on older hardware that cannot sustain high-frame rates (like a 10yr old macbook), can't promise anything but I'll let you know if that work gets merged.

iBongiornor commented 4 months ago

same issue on latest release. so sad. hope fix as soon as possibile

sfclub commented 2 months ago

In version Zed 0.149.5, everything seems to be fine, the jambs with the display are fixed!

CurbaiCode commented 2 months ago

It's working for me too now!

notpeter commented 2 months ago

I'm going to go ahead and close this. Very happy this was able to get solved to keep some older hardware useful for a bit longer. Thanks everyone for chiming in.

Labrium commented 2 months ago

I tested with both 0.149.5 and the latest version at the time of writing: 0.152.3, but I'm still experiencing the same issue.

I find it quite strange that the same bug is only fixed for some of the affected machines.

notpeter commented 2 months ago

@Labrium Your iMac is the outlier here, please see my comment above.

Zed's GPU rendering is built on Metal2 and the GeForce 750m never fully supported Metal2 properly. The reason other users are reporting success is that Zed is using their Intel Iris Pro GPU instead of the Nvidia GPU on their machines. Sadly your iMac shipped with the Intel HD Graphics 4600 (not the Iris Pro) which Apple never unlocked for usage in MacOS -- so you're forced to use the (still broken) Nvidia Metal2 implementation. Sorry!