Add macOS borderless fullscreen mode

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.

https://zed.dev

Other

50.7k stars 3.14k forks source link

Add macOS borderless fullscreen mode #7257

Open diocletiann opened 9 months ago

diocletiann commented 9 months ago

Check for existing issues

[X] Completed

Describe the feature

It's more useful than native since you can still have windows behind it and cmd-tab without changing spaces and waiting for the slide animation. It would also allow for opening new Zed windows in the current space without new spaces being created at the tail.

If applicable, add mockups / screenshots to help present your vision of the feature

No response

JosephTLyons commented 9 months ago

Hey @diocletiann, I'm trying to understand the request here. Are you wanting an action that just expands the window out to the full height and width of the screen, but without entering into macOS' full screen mode? And if so, how do you see that being trigggerd? A command palette action, key binding, or UI element?

diocletiann commented 9 months ago

@JosephTLyons I'm referring to the old macOS fullscreen mode that didn't create a dedicated space, aka borderless. What some apps do is have a config option for the fullscreen mode type and the user can choose native or borderless.

mrnugget commented 9 months ago

Ah, you want the non-native fullscreen, right? I love that. I added it to Ghostty and my proof-of-concept is here: https://github.com/mrnugget/non-native-fullscreen In Ghostty it's grown more complex because you need to respect the notch on MacBooks, stuff moving from window to window, etc. But I think it could be relatively straightforward.

diocletiann commented 9 months ago

Thank you fellow traveler! The Ghostty implementation works great btw.

quinn commented 7 months ago

I would love this feature too, here's some context from the kitty project:

https://github.com/kovidgoyal/kitty/issues/3100

that issue provides a link to the iterm implementation:

https://github.com/gnachman/iTerm2/blob/75b2165fe62f45043dbe59c9e38d018bd82e7f15/sources/PseudoTerminal%2BWindowStyle.m#L517

elliotbonneville commented 6 months ago

Any movement here? This would be amazing to have.

Jackevansevo commented 3 weeks ago

For some more context, in Iterm2 this feature is called "Native full screen windows". Would also be interested to see something similar in Zed.