search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
49.27k stars 2.98k forks source link

can't use defined 'selection' color in terminal #7532

Closed tecandrew closed 8 months ago

tecandrew commented 8 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

using a custom Cursor color works, but Selection within the terminal uses the same cursor color making it difficult to read sometimes.

the selection-highlight color only works in the editor pane.

This selection/cursor coloring wasn't documented in the https://zed.dev/schema/themes/v0.1.0.json, just kind of ran into it when trying to fix Catppuccin theming

Environment

Zed: v0.122.1 (Zed Preview) OS: macOS 14.3.0 Memory: 16 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

image

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

mikesun commented 8 months ago

I think this is fixed by https://github.com/zed-industries/zed/commit/d959719f3e18a06cfcd962f4c9c435316a42ce88 and is in https://github.com/zed-industries/zed/releases/tag/v0.123.2-pre

tecandrew commented 8 months ago

awesome! looks like it is fixed in Zed Preview! image