terminal: text overlaps UI (tabs)

[avetisk]

Check for existing issues

• [X] Completed

Describe the bug / provide steps to reproduce it

As you can see in the picture below the | is overlapping the tab.

Here's my terminal config in Zed:

  "terminal": {
    "alternate_scroll": "on",
    "blinking": "terminal_controlled",
    "copy_on_select": true,
    "default_width": 640,
    "dock": "right",
    "env": {},
    "font_family": "Victor Mono",
    "font_size": 14,
    "line_height": "standard",
    "working_directory": "current_project_directory"
  }

Environment

Zed: v0.121.5 (Zed) OS: macOS 14.3.0 Memory: 24 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

If you only need the most recent lines, you can run the zed: open log command palette action to see the last 1000.

No response

[rubjo]

Font author here (who happened to file an issue just around the same time as you 😄 ). I'm not seeing the same on my setup.

You could try a few things:

• Omitting the whole "line_height": "standard", line
• If you're using the version downloaded from the font web site, try the Google Fonts distribution of Victor Mono instead, it has some minor adjustments
• Trying the Nerd Fonts variant of Victor Mono instead

[avetisk]

• Omitting the whole "line_height": "standard", line

Can't do that, I want to have a small line height :)

• If you're using the version downloaded from the font web site, try the Google Fonts distribution of Victor Mono instead, it has some minor adjustments

Tried it, didn't work (I had to remove 2px from the font size I had set though)

• Trying the Nerd Fonts variant of Victor Mono instead

Same, still having the issue.

I think beyond the issue with the font, the terminal should clip the overflow.

BTW, @rubjo a huge thank for the Victor Mono font, it's been my favorite since I got ❤️🙏

[rubjo]

Anyway, it's probably not | but rather │ (box-drawing character U+2502), which might not be straightforward to fix.

[avetisk]

Indeed, but I still think the issue is not the font but the way the overflow is handled.

The CSS equivalent of the terminal's viewport should be overflow: hidden.