search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
49.5k stars 3.02k forks source link

Add "Find In Project" button and keyboard shortcut #7836

Open gbrrrl-no opened 8 months ago

gbrrrl-no commented 8 months ago

Check for existing issues

Describe the feature

In VS Code we have a button represented by this magnifying glass that allows us to search for things in the entire project. In Zed we have a similar feature called Find In Project, but it's way too inaccessible (Menubar > Edit > Find In Project).

Screenshot 2024-02-15 at 11 43 43

I use this feature a lot and it really slows me down having to navigate on the menubar to find it, specially since I use my editor on full screen mode. I'd love if Zed had a find in project icon next to the project panel and added a keyboard shortcut similar to VS Code (Cmd + Shift + F).

If applicable, add mockups / screenshots to help present your vision of the feature

The idea is that there's a magnifying glass icon right next to the Project Panel icon

Screenshot 2024-02-15 at 11 51 18


And a keyboard shortcut (maybe Cmd + Shift + F) for Find In Project.

Screenshot 2024-02-15 at 11 52 05
gbrrrl-no commented 8 months ago

I am aware I can just add a custom keyboard shortcut through Mac's System Settings, but having this implemented natively would be nice :)

mrnugget commented 8 months ago

We do have the ctrl-shift-f keyboard shortcut already. Does that fix your problem?

The bug here seems to be that we don't show that keybinding in the macOS menu.

https://github.com/zed-industries/zed/assets/1185253/3a895ff9-675b-488e-a1fe-e562af86ae6c

gbrrrl-no commented 8 months ago

Oh that helps a lot, but having a dedicated button would still be nice. This nice though!

HarshNarayanJha commented 3 weeks ago

I would like to tackle this.

image