search

zed-industries / zed

Code at the speed of thought – Zed is a high-performance, multiplayer code editor from the creators of Atom and Tree-sitter.
https://zed.dev
Other
47.75k stars 2.79k forks source link

Collaborate feature "Screen share" doesn't work #9029

Open dimeeentor opened 6 months ago

dimeeentor commented 6 months ago

Check for existing issues

Describe the bug / provide steps to reproduce it

  1. Add a contact
  2. Call the contact

I thought I could collaborate with my friend, however when we connect, then couple of seconds – we are disconnected. On both Macs we've enable "Screen and audio sharing".

Environment

Zed: v0.125.3 (Zed) OS: macOS 14.3.1 Memory: 16 GiB Architecture: aarch64

If applicable, add mockups / screenshots to help explain present your vision of the feature

No response

If applicable, attach your ~/Library/Logs/Zed/Zed.log file to this issue.

These logs from the Console macOS app:

2024-03-07T19:06:50+01:00 [ERROR] server stderr: Some("") 2024-03-07T19:06:50+01:00 [INFO] retrying installation of language server "ocamllsp" in 1s 2024-03-07T19:06:51+01:00 [INFO] connected to rpc endpoint https://collab.zed.dev/rpc 2024-03-07T19:06:51+01:00 [INFO] add connection to peer 2024-03-07T19:06:51+01:00 [INFO] waiting for server hello 2024-03-07T19:06:51+01:00 [INFO] got server hello 2024-03-07T19:06:51+01:00 [INFO] set status to connected (connection id: ConnectionId { owner_id: 0, id: 0 }, peer id: PeerId { owner_id: 366, id: 212316 }) 2024-03-07T19:06:51+01:00 [INFO] set status on client 136924: Connected { peer_id: PeerId { owner_id: 366, id: 212316 }, connection_id: ConnectionId { owner_id: 0, id: 0 } } 2024-03-07T19:06:51+01:00 [INFO] Validation check requested for "ocamllsp" but it cannot be reinstalled 2024-03-07T19:06:54+01:00 [INFO] published audio track TR_AMVsU7iNAMHYh9 2024-03-07T19:06:56+01:00 [INFO] published video track TR_VSQ8Qe36BDfyUY 2024-03-07T19:07:40+01:00 [INFO] room is empty, leaving 2024-03-07T19:07:40+01:00 [INFO] leaving room 2024-03-07T19:07:40+01:00 [ERROR] crates/project/src/project.rs:1364: share ended 2024-03-07T19:07:40+01:00 [INFO] unhandled message RoomUpdated 2024-03-07T19:09:28+01:00 [INFO] published audio track TR_AMFuuudjmUYV8X 2024-03-07T19:09:30+01:00 [INFO] published video track TR_VSRLJEXtHEkcZd 2024-03-07T19:09:33+01:00 [INFO] unhandled message Unfollow 2024-03-07T19:09:41+01:00 [INFO] room is empty, leaving 2024-03-07T19:09:41+01:00 [INFO] leaving room 2024-03-07T19:09:41+01:00 [ERROR] crates/project/src/project.rs:1364: share ended 2024-03-07T19:09:41+01:00 [INFO] unhandled message RoomUpdated 2024-03-07T19:11:16+01:00 [INFO] published audio track TR_AMAP9T9QJHutNh 2024-03-07T19:11:28+01:00 [INFO] room is empty, leaving 2024-03-07T19:11:28+01:00 [INFO] leaving room 2024-03-07T19:11:28+01:00 [ERROR] crates/project/src/project.rs:1364: share ended 2024-03-07T19:11:28+01:00 [INFO] unhandled message RoomUpdated 2024-03-07T19:11:31+01:00 [INFO] published audio track TR_AMDFx49HUfSLQR 2024-03-07T19:11:54+01:00 [INFO] leaving room 2024-03-07T19:11:54+01:00 [ERROR] crates/project/src/project.rs:1364: share ended 2024-03-07T19:11:54+01:00 [INFO] unhandled message RoomUpdated 2024-03-07T19:11:59+01:00 [INFO] published audio track TR_AMU6KiietDkrJU 2024-03-07T19:12:07+01:00 [INFO] leaving room 2024-03-07T19:12:07+01:00 [ERROR] crates/project/src/project.rs:1364: share ended 2024-03-07T19:12:07+01:00 [INFO] unhandled message RoomUpdated 2024-03-07T19:12:10+01:00 [INFO] published audio track TR_AMVVXaAZzPgXaX 2024-03-07T19:12:21+01:00 [INFO] room is empty, leaving 2024-03-07T19:12:21+01:00 [INFO] leaving room 2024-03-07T19:12:21+01:00 [ERROR] crates/project/src/project.rs:1364: share ended 2024-03-07T19:12:22+01:00 [INFO] unhandled message RoomUpdated

Moshyfawn commented 6 months ago

@dimeeentor Can you still reproduce the problem on your end? There was some downtime, but it should be fixed now.

Ref: #9021

dimeeentor commented 6 months ago

@Moshyfawn The problem still reproducible.

https://github.com/zed-industries/zed/assets/32683179/39c1bdac-c665-4c7d-9e65-0a9230fde83d

dimeeentor commented 6 months ago

Also, tried to use "Channels". Tested it a bit, then tried to delete and got this:

2024-03-07T21:49:17+01:00 [INFO] published audio track TR_AMbzxLcMRiNJRG 2024-03-07T21:49:31+01:00 [INFO] room is empty, leaving 2024-03-07T21:49:31+01:00 [INFO] leaving room 2024-03-07T21:49:31+01:00 [ERROR] crates/project/src/project.rs:1364: share ended 2024-03-07T21:49:31+01:00 [INFO] unhandled message RoomUpdated 2024-03-07T21:53:02+01:00 [INFO] published audio track TR_AMRLKFrobwYUqH 2024-03-07T21:53:09+01:00 [WARN] incoming response: unknown request connection_id=0/0 message_id=73 responding_to=78 message_type="Ack" 2024-03-07T21:54:21+01:00 [ERROR] crates/project/src/project.rs:1364: share ended 2024-03-07T21:54:28+01:00 [ERROR] TODO RPC request DeleteChannel failed: Execution Error: error returned from database: update or delete on table "rooms" violates foreign key constraint "room_participants_room_id_fkey" on table "room_participants"

notpeter commented 3 months ago

Also, tried to use "Channels". Tested it a bit, then tried to delete and got this:

2024-03-07T21:54:28+01:00 [ERROR] TODO RPC request DeleteChannel failed: Execution Error: error returned from database: update or delete on table "rooms" violates foreign key constraint "room_participants_room_id_fkey" on table "room_participants"

I ran into this as well. It occurs because you can't delete a channel you have currently joined. If you leave the channel you can then delete should work. See also

Apologies for the delay, but to follow up on the original issue are you still experiencing this problem when you try and screen share?