zedapp / zed

Rethinking code editing.
http://zedapp.org
MIT License
2.22k stars 162 forks source link

Open BitBucket private repo #464

Open GitHubGeek opened 10 years ago

GitHubGeek commented 10 years ago

Dear Zedapp Team,

Any plan for supporting this? Thanks!

zefhemel commented 10 years ago

It will be much more difficult to implement than github support, because bit bucket doesn't have nice REST APIs for this stuff like GitHub does. Only way would be to actually use git implemented in JS (like @creationix' js-git). — Zef

Sent from my iPhone

On Fri, Sep 19, 2014 at 3:30 AM, Jay Yu notifications@github.com wrote:

Dear Zedapp Team,

Any plan for supporting this? Thanks!

Reply to this email directly or view it on GitHub: https://github.com/zedapp/zed/issues/464

creationix commented 10 years ago

I have git clone implemented over https with a test site . The problem is bitbucket and github don't add CORS headers to the pack-protocol server.

https://bitbucket.org/site/master/issue/6666/detect-git-requests-by-content-type-header https://bitbucket.org/site/master/issue/8846/enable-cors-header-for-git-repo-https

zefhemel commented 10 years ago

That's not an issue in a Chrome App, though, right?— Zef

Sent from my iPhone

On Fri, Sep 19, 2014 at 5:13 PM, Tim Caswell notifications@github.com wrote:

I have git clone implemented over https with a test site . The problem is bitbucket and github don't add CORS headers to the pack-protocol server. https://bitbucket.org/site/master/issue/6666/detect-git-requests-by-content-type-header

https://bitbucket.org/site/master/issue/8846/enable-cors-header-for-git-repo-https

Reply to this email directly or view it on GitHub: https://github.com/zedapp/zed/issues/464#issuecomment-56190617

creationix commented 10 years ago

The CORS headers aren't an issue in chrome apps, but the user-agent checking issue at bitbucket is if you use XHR, but using my http-codec library, you can implement your own http client on top of chrome.sockets and set your own custom user-agent string.