Closed ghost closed 9 years ago
Very nice
I will have to change the keys, though. Alt-up and Alt-down are already taken...
I changed them to Ctrl-PageUp
and Ctrl-PageDown
. Not great, but we're running out of keys.
Heh, i didn't even notice that alt up and down were taken.
Your choice works fine for me, it's ctrl+fn+up/down on my keyboard anyway.
Thanks for merging! On Mar 1, 2015 11:34 PM, "Zef Hemel" notifications@github.com wrote:
I changed them to Ctrl-PageUp and Ctrl-PageDown. Not great, but we're running out of keys.
— Reply to this email directly or view it on GitHub https://github.com/zedapp/zed/pull/517#issuecomment-76669112.
There's a script to check this stuff:
node script/verify_keys_overload.js
If it doesn't print anything all is OK.
On Mon, Mar 2, 2015 at 9:52 AM Robert Bruce Park notifications@github.com wrote:
Heh, i didn't even notice that alt up and down were taken.
Your choice works fine for me, it's ctrl+fn+up/down on my keyboard anyway.
Thanks for merging! On Mar 1, 2015 11:34 PM, "Zef Hemel" notifications@github.com wrote:
I changed them to Ctrl-PageUp and Ctrl-PageDown. Not great, but we're running out of keys.
— Reply to this email directly or view it on GitHub https://github.com/zedapp/zed/pull/517#issuecomment-76669112.
— Reply to this email directly or view it on GitHub https://github.com/zedapp/zed/pull/517#issuecomment-76676592.
Ah, apologies, this PR also includes the other one for open_line.js. Merge that one first and then this diff will look sensible ;-)
Let me know what you think about the keybinds. I wanted
Ctrl+Up/Down
for the motion andAlt-h
(emacs style) for the selection, but those were all taken, so I kinda just grabbed whatever was available.