search

zedapp / zed

Rethinking code editing.
http://zedapp.org
MIT License
2.22k stars 161 forks source link

Use double quotes for all json, add .zedstate to gitignore #575

Closed ryanpcmcquen closed 8 years ago

ryanpcmcquen commented 8 years ago

Signed-off-by: Ryan Roadside ryan@roadsidemultimedia.com

ryanpcmcquen commented 8 years ago

I know leaving out the double quotes doesn't break anything, but this looks so much better:

BEFORE: screen shot 2015-12-02 at 9 20 03 am

AFTER: screen shot 2015-12-02 at 9 20 34 am

zefhemel commented 8 years ago

I think this is a matter of taste :smile: The format used is JSON5, not JSON (JSON5 allows unquoted JSON among other things like comments). We used JSON before, but JSON5 feels cleaner. Most of the modes, themes etc. have been migrated to JSON5, so this PR only touches about 1% of all the JSON in the system.

ryanpcmcquen commented 8 years ago

Well in that case, I'll just rebase this to add .zedstate to the .gitignore. I agree that it looks better without quotes overall, hopefully :octocat: will update his syntax highlighting. :wink:

ryanpcmcquen commented 8 years ago

Actually, I see now that you have the wildcard (.*) for hidden files in there. Nevermind!