search

zedchance / blues_bot.py

A verified Discord bot for Old School Runescape written in Python
https://github.com/zedchance/blues_bot.py/wiki
MIT License
5 stars 9 forks source link

Items JSON file is out of date #11

Closed zedchance closed 4 years ago

zedchance commented 4 years ago

I don't remember where I found the file assets/item_ids.json, (it was somewhere on a reddit page that linked to a paste bin), but it is definitely out of date as they have been adding a lot of new items recently. The price lookup command utilizes this file to search for items on the Grand Exchange.

I did it this way because it happened to be relatively easy. Another way could be to request a query from the API, then search the response for item names and find their ID that way.

Alternatively a new up to date .json file could be used, but for "future-proofness" I'm leaning toward the other option.

zedchance commented 4 years ago

I addressed this in a6d9bc95753267c596bd7e821ee2d4272609fd23