search

zeddicus-pl / d2rHolyGrail

34 stars 8 forks source link

Idea - save items you've found, even if you don't have it stored on your char #6

Open cwn-dev opened 2 years ago

cwn-dev commented 2 years ago

Holy Grail storage is awkward in D2R. You either have to make a bunch of mule characters, or use something like D2 Collection Manager to transfer items to a Plugy stash - very awkward and time consuming.

My idea is to have an option 'Save Grail Progress'?, which means items that have been found will be saved in the app somewhere (simple json file would probably be fine), so you can drop/sell that item again, but you could also complete the grail.

I may be able to find some time to implement this myself at some point, but not sure how soon that'll be. Happy for someone else to take this!

ktunkiewicz commented 2 years ago

I like the idea too, however I had very little time recently to work on hobby projects. That idea is on the list of ideas for some time already. Any ideas on how this could be implemented? I mean, should it only note the time and character name, or maybe do something more like saving the copy of the save, or saving the item details itself etc.? Also how should that be presented in the UI

borisblagov commented 2 years ago

Great idea. I found that if I find the item and I drop it, it disappears from my Grail (btw, since 2.5 my progress went down in the app, don't know why).

What @cwn-dev is saying, I think, is for the app to simply make a check mark that the item is found. Not to store the item or copy the save file in any way, simply to allow me to drop the item and have it forever stored as "found".

cwn-dev commented 2 years ago

I like the idea too, however I had very little time recently to work on hobby projects. That idea is on the list of ideas for some time already. Any ideas on how this could be implemented? I mean, should it only note the time and character name, or maybe do something more like saving the copy of the save, or saving the item details itself etc.? Also how should that be presented in the UI

I had a quick look through the source code and realised there's a 'manual' mode where you can track what you've found manually, therefore there must be some kind of database or way of storing found items already.

So, with that in mind, I would propose that if you have 'Save Grail Progress' switched on, then effectively, when a new item is found, it's added to the manual tracking database/file (I am unsure how manually tracked grails are stored at the moment).

Character name and date/time found would be nice, but I don't see that as absolutely necessary.

borisblagov commented 2 years ago

When installing the grail, you can choose whether to tick them off manually or to use the savefiles. Since I already have a lot I choose savefiles, but there is no option to "go back".

shupershuff commented 10 months ago

+1 on this. It should ideally store this in some kind of DB file or .json as OP suggested. This could also track other metadata such as when the item was first found, how many times it was found.