search

zedtux / nginx-proxy

Automated nginx proxy for Docker containers using docker-gen
15 stars 6 forks source link

MAX_UPLOAD_SIZE broken when more than one upstream #9

Open jperville opened 9 years ago

jperville commented 9 years ago

I tried to use the MAX_UPLOAD_SIZE feature for a virtualhost with 2 load-balanced upstream containers. It was broken because of nginx syntax error, as explained below.

The current nginx template will output as many client_max_body_size directives as there are containers, which means nginx -t will fail to parse the configuration in /etc/nginx/sites-enabled/default ; in the best case the old configuration will keep being used and in the worst case the container won't start at all.

I have proposed jwilder/nginx-proxy#76 to solve the issue, feel free to port the fix to your fork too.

zedtux commented 9 years ago

Nice, thank you @jperville I will port the fix to my fork.

zedtux commented 6 years ago

This repository has been migrated to GitLab and this issue too. Move to the right place now!