zeebe-io / zeebe-modeler

Desktop Application for modeling Zeebe Workflows with BPMN
MIT License
221 stars 49 forks source link

Improve sync script #259

Closed barmac closed 4 years ago

barmac commented 4 years ago

This is not implemented as I couldn't set it up correctly together with git merge (fetch with --no-tags made it impossible to refer to the tag later).

This apparently works correctly after update of simple-git.

Which issue does this PR address?

Closes #247

Definition of Done

pinussilvestrus commented 4 years ago

Fetch only a single tag or branch from upstream repository

I guess this is not so urgent anymore since we make sure to delete all un-related tags afterward in any case?

I'd be fine to move this item into another issue which we might fix in the future then.

barmac commented 4 years ago

I've run a test sync on my machine and there were no Camunda Modeler tags present afterwards.

I believe the problem occurs only when you already have a Camunda Modeler remote configured when you run the sync script. Do you think it's reasonable to remove the remote configuration in that case?

pinussilvestrus commented 4 years ago

I'd say it's cleaner to make sure you always have a fresh remote configuration when executing the sync. Therefore it makes sense, in case you have the remote already present, to delete and re-create it.

barmac commented 4 years ago

Ok, then I'll add a cleanup of the tags before sync is run.

barmac commented 4 years ago

Ready for review.

barmac commented 4 years ago

I don't think it's necessary as we perform a full cleanup now.

pinussilvestrus commented 4 years ago

🚀 Thanks for improving the kind of outdated sync script 👍

barmac commented 4 years ago

I think there's still room for improvement when it comes to the ignored files. I'll have another issue for that.