zeebe-io / zeebe-modeler

Desktop Application for modeling Zeebe Workflows with BPMN
MIT License
220 stars 48 forks source link

Add process id of participant to properties panel #284

Closed azeghers closed 3 years ago

azeghers commented 3 years ago

Closes #278

Adds the inputs to edit a participant's process name and id to the properties panel.

Acceptance Criteria

Definition of Done

MaxTru commented 3 years ago

Added @andreasgeier for review via modeling-design

andreasgeier commented 3 years ago

In the current state, I can see and edit new fields for the Process ID and Process Name. So basically, the issue is fixed.

From the UX perspective, it would be an improvement when we are always specific with the process and participant labels like Ingo described here. I understand that this is a generic component and the generic labels are used for all elements but these two are main elements. Moreover: for the process we do not even have a selection marker. And having attributes of two elements in a property panel is also questionable. All of this speaks in favor of specific labels for both.

nikku commented 3 years ago

All of this speaks in favor of specific labels for both.

You think of Process Id / Process Name and Participant Id / Participant Name here or what would be your suggestion?

andreasgeier commented 3 years ago

Exactly

nikku commented 3 years ago

I agree that this would improve things and it is an easy pick, too.

@azeghers Would you be O.K. with shipping that additional improvement as a follow up to this PR? We'd need to improve it in both apps, of course.