zeebe-io / zeebe-modeler

Desktop Application for modeling Zeebe Workflows with BPMN
MIT License
220 stars 48 forks source link

feat(deployment): use last endpoint deployed for all files #285

Closed azeghers closed 3 years ago

azeghers commented 3 years ago

In accordance with https://github.com/bpmn-io/internal-docs/issues/224, this PR aligns the Zeebe Modeler deployment plugin with the Camunda Modeler one.

Which issue does this PR address?

Closes #227

Acceptance Criteria

Definition of Done

azeghers commented 3 years ago

Small finding, the test covering this section only tests with a single saved endpoint, which wasn't very useful back when the deployment tool could handle multiple endpoints. The test is now appropriate without modification.

pinussilvestrus commented 3 years ago

Just to understand it correctly: We ignore the multi-endpoint concept for now and use the same endpoint globally for every file, right? Because this is what I experienced when trying it out

And so on. So basically there is currently only one global endpoint being used for all diagrams. Is this the intended behavior?

It's actually the same in Camunda Modeler, so I guess the answer is "yes" 😄

azeghers commented 3 years ago

@pinussilvestrus That's correct.

pinussilvestrus commented 3 years ago

Works well for me 👍 Just some thoughts for possible code changes.