zeebe-io / zeebe-modeler

Desktop Application for modeling Zeebe Workflows with BPMN
MIT License
220 stars 48 forks source link

The UI incorrectly complains when FEEL expressions are used in Call activity Process ids #290

Open allanbarklie opened 3 years ago

allanbarklie commented 3 years ago

Describe the Bug

The UI incorrectly complains if a FEEL expression is entered for a call activity process id. It complains that the string is not a QName.

Steps to Reproduce

  1. Create a workflow with a call activity
  2. Enter a FEEL expression for the call activity process ID
  3. The UI displays an error

Expected Behavior

The UI should allow FEEL expressions as Zeebe supports FEEL expressions for this field (and the broker correctly respects any FEEL expressions in this field).

Note - it looks like work on the bug https://github.com/zeebe-io/zeebe-modeler/issues/237 and the introduction of FEEL expressions happened in parallel and this sneaked in - maybe the validation needs to assert that the value is either a QName or a FEEL expression

Environment

MaxTru commented 3 years ago

Thanks for reporting this - indeed it seems like this sneeked it with the referenced bugFix. We will tackle this.

WilliamsDL commented 3 years ago

Is there a workaround I can use? This is a blocker for me. I need to be able to dynamically pass in the process Id.

allanbarklie commented 3 years ago

@WilliamsDL I'm currently using the previous version as my workaround