search

zeeguu / api

API for tracking a learner's progress when reading materials in a foreign language and recommending further personalized exercises and readings.
https://zeeguu.org
MIT License
7 stars 18 forks source link

fix of subscribe to search - an open issue in the web #459 #190

Closed KlaraK94 closed 1 week ago

KlaraK94 commented 3 weeks ago

With the last changes, we made sure no duplications were added to search (after discussion with Mircea). But I do think duplications is necessary. The users can both add the same search subscription, but the issue is when removing the subscription again. Because there should then be two objects, where each user can delete "their own". But not having duplications results in only one object in the database, and neither/only one can remove the search.

This is a fix of an open issue in the web, https://github.com/zeeguu/web/issues/459.

github-actions[bot] commented 3 weeks ago

Module view diffs: diff

KlaraK94 commented 2 weeks ago

It makes sense to not have duplications in the code. Thank you for the fix!

mircealungu commented 1 week ago

closing this as it has been solved by @tfnribeiro in #191