search

zeek / cmake

CMake scripts used in Zeek
https://www.zeek.org
Other
48 stars 59 forks source link

Support pointing `BROKER_ROOT_DIR` at Zeek build tree #108

Closed J-Gras closed 6 months ago

J-Gras commented 6 months ago

I think this is needed if you want to point BROKER_ROOT_DIR into Zeek's build tree after https://github.com/zeek/broker/commit/3c64a311d802348f020eaf3eda3042d4d9cb4b1d.

Neverlord commented 6 months ago

That script is obsolete. We guard against CMake picking this up by accident: https://github.com/zeek/zeek/blob/master/src/ZeekConfig.cmake.in#L30. Is that guard not working for you? How did you end up in that script?

J-Gras commented 6 months ago

Oh, I am using that script in an external project to find Broker. Is there another way to do that now?

Neverlord commented 6 months ago

The "proper" CMake way is to use the CMake package config files. If there a legacy Find<PackageName> script on your system, you can pass CONFIG to find_package to tell CMake to not fall back on the legacy scripts ("config mode": https://cmake.org/cmake/help/latest/command/find_package.html).

That script definitely should no longer exists and I actually though we've removed it a while ago. Sorry for the inconvenience!

J-Gras commented 6 months ago

Thanks 🙏 I'll close this and reach out if I run into any issues implementing the proper integration.