zeek / cmake

CMake scripts used in Zeek
https://www.zeek.org
Other
48 stars 59 forks source link

ZeekPluginDynamic: Handle DIST_FILES in CMake #116

Closed awelzel closed 5 months ago

awelzel commented 5 months ago

Move path wrangling of DIST files from zeek-plugin-create-package.sh into CMake logic.

New logic: Relative paths have all leading ../ components strip to determine the location within the resulting tarball. This also removes the assumption of having build/ located within the source directory (and zeek-plugin-create-package.sh running from build/).

The quirky part is that the script deletes the produced files after creating the tarball.

awelzel commented 5 months ago

@bbannier - this is what maybe could work for https://github.com/zeek/package-template/pull/37#pullrequestreview-2142089742 in the future. Is this more in the direction you were thinking of?

awelzel commented 5 months ago

🚀

Grumble - this subtly changes how we deal with symlinks: Having README a symlink as README.md will place README.md into the tarball due to the resolving the path. I think this would be better with ABSOLUTE rather than REALPATH. I'll try.