search

zeek / package-manager

A package manager for Zeek
https://docs.zeek.org/projects/package-manager
Other
43 stars 27 forks source link

zkg refresh --aggregate does not warn if there is no bro-pkg/zkg.meta file in repo #75

Closed 0xxon closed 4 years ago

0xxon commented 4 years ago

I just realized that zkg refresh --aggregate apparently does not complain at all if there is no (or no valid?) bro-pkg or zkg.meta file in a repository.

It would be nice to have some kind of warning output in these cases.

jsiwek commented 4 years ago

In zkg v2.4.0, there's now a warning like this:

$ zkg refresh --aggregate
Refresh package source: zeek
    Changes:
        Added zeek/zeek/spicy-runtime
        Added zeek/reservoirlabs/zeek-pdf-analyzer
        Added zeek/corelight/CVE-2020-5902-F5BigIP
        Added zeek/corelight/CVE-2020-16898
        ...
    WARNING: Metadata aggregated, but excludes the following packages due to described problems:
        https://github.com/initconf/smtp-url-analysis: missing zkg.meta (or bro-pkg.meta) metadata file
Refresh installed packages
    No new outdated packages

In previous versions, there was also a warning, but hidden unless verbosity is increased with zkg -v refresh --aggregate.

(I opened a PR for that one currently failing package a bit ago: https://github.com/initconf/smtp-url-analysis/pull/7)