search

zeek / package-website

New version of packages website
BSD 3-Clause "New" or "Revised" License
3 stars 1 forks source link

README issues #47

Open cjb873 opened 11 months ago

cjb873 commented 11 months ago

Some readme files are not being properly downloaded

ckreibich commented 11 months ago

Thanks for the ticket, you beat me to it. Here's an example of a package where it seems to fail: https://github.com/corelight/zeek-community-id

cjb873 commented 11 months ago

This package returns 200 for HTTP requests to both README.md and README. All of the actual content is stored within README, not README.md. Since we try README.md first and it does return 200, we are currently using the content for that. I'll figure something out to fix this issue.

ckreibich commented 11 months ago

You're right, I'm seeing this too. Looks like at the HTTP level the fact that README.md is a symlink to README gets lost (that's why the content just says "README" — funny). You could try some heuristics, or perhaps the Github API lets you spot the difference and it's time to use that if you're not already doing so.

Thanks for looking into it.