search

zeek / spicy

C++ parser generator for dissecting protocols & files.
https://docs.zeek.org/projects/spicy
Other
243 stars 37 forks source link

Deprecate use of `result` and `network` #1770

Closed J-Gras closed 2 months ago

J-Gras commented 2 months ago

Given that result and network are common terms, I would prefer a deprecation before introducing them as new keywords.

bbannier commented 2 months ago

Thanks for raising this. I agree that introducing these new keywords without a deprecation cycle is not ideal. Since these are not in the runtime library, but built into the parser, adding a deprecation for them would mean at minimum adding new code to the parser so it does context sensitive parsing, e.g., allow result as a variable or function name; we likely would still need to reject result as a name for user-defined types though. This would be code for a 3 month transition period. All this seems both complicated and incomplete, so I am feeling we should not attempt it. I am closing this for now.