zeek / spicy

C++ parser generator for dissecting protocols & files.
https://docs.zeek.org/projects/spicy
Other
243 stars 37 forks source link

[WIP] Apply `&on-heap` selectively #1781

Open rsmmr opened 1 month ago

rsmmr commented 1 month ago

In our generated C++ parsing code, so far we generally moved all units to the heap. This PR changes that to do so only for cases where we actually need it (primarily: if we wrap the unit into a reference somewhere, or if the unit type is cyclic). The assumption is that this should improve both performance and memory usage.

rsmmr commented 2 weeks ago

Rebased on top of #1833, now using our new AST dependency tracking.

Test suite still fails because of #1831.

rsmmr commented 2 weeks ago

With #1833 and #1834 merged, this is now rebased on main.

Still not sure if we want this or not due to runtime performance concerns.