search

zeek / spicy

C++ parser generator for dissecting protocols & files.
https://docs.zeek.org/projects/spicy
Other
243 stars 37 forks source link

Do not search for Python in CMake setup. #1802

Closed bbannier closed 1 month ago

bbannier commented 1 month ago

We previously needed this since during the build we were generating files with Python. This is not the case anymore.

bbannier commented 1 month ago

Given the that the test suite and docs generation requires Python, a better alternative would be to put (for testing and documentation) rather than completely excluding it? The pip commands following make this now implicit.

EDIT: There's some more mentioning of python in the macOS section.

Yeah, I am wondering if I shouldn't just leave the docs as is since this is becoming pretty tricky: the only direct requirement for python3 would be from pre-commit hooks, but to install them one would either need to install pre-commit with pip, or if using a system package it would pull in Python as a dependency. The situation is similar for building the docs which just needs Sphinx (which only requires Python indirectly), and BTest (probably impossible to install without pip which requires Python).

Let me instead move the Python dependency to the For testing and For building the documentation sections.