to_int() ubsan fixes - Githubissues

zeek / spicy

C++ parser generator for dissecting protocols & files.

https://docs.zeek.org/projects/spicy

Other

249 stars 37 forks source link

Closed awelzel closed 3 months ago

awelzel commented 3 months ago

Reject empty byte ranges for to_uint(ByteOrder).
Fix shifting of 32bit value, causing to_int(ByteOrder) to return bogus values.

awelzel commented 3 months ago

Could you do that? They are defined in hilti/toolchain/src/ast/operators/bytes.cc.

I've done that now. Still not sure what exactly to use as exceptions, but RuntimeError is at least not totally wrong in the docs...

bbannier commented 3 months ago

Backported to release/1.11.