zeek / zeek-client

Experimental implementation of Zeek's future cluster management client
BSD 3-Clause "New" or "Revised" License
4 stars 4 forks source link

fix `deploy-config`/`stage-config` bug relative to `cpu_affinity` config field #37

Closed lydiym closed 4 months ago

lydiym commented 1 year ago

What

There is bug with cpu_affinity field in deploy configuration. When it's placed in config, commands like deploy-config/stage-config fail with "request timed out" error. Controller expects an Integer type for the field but actually gets the Count.

The pull request provides a solution

How

Just by correcting type for cpu_affinity

Relative issues

Closes #34

ckreibich commented 1 year ago

Thank you for this! I'm doing some testing to understand why this leads to a timeout, and will merge this shortly thereafter. I could have sworn the zeek-testing-cluster testsuite has a testcase that already covers CPU affinity, but it indeed doesn't.