zeek / zeek-docs

Documentation for Zeek
https://docs.zeek.org
Other
50 stars 70 forks source link

broker: Proxies aren't actually optional #177

Closed awelzel closed 1 year ago

awelzel commented 1 year ago

Skimming the base scripts for proxy_topic or proxy_pool, it seems specifically base/frameworks/software uses proxy_pool unconditionally without a fallback.

I introduced that sentence recently, I'm not sure if I had picked that up elsewhere, or just assumed because mostly things work without proxies and there's no warning or so (which maybe we should add).

ckreibich commented 1 year ago

Nice catch. This is pretty bad since nothing complains if you don't spin up proxies — looks like Cluster::publish_hrw() returns F if there are no nodes in the pool, but we're not actually checking that in any of its uses.