zeel01 / MonsterBlocks

A Foundry VTT module to add NPC sheets that faithfully reproduce the appearance of D&D 5e monster statblocks.
29 stars 26 forks source link

Foundry V10 Support #198

Closed gaffdninja closed 2 years ago

gaffdninja commented 2 years ago

Will this module be updated for version 10 support? My games are not the same without them. In any case keep up the good work :)

zeel01 commented 2 years ago

It will.

DarioRomano commented 2 years ago

It will.

Thank you for the information, and another big thank you for creating and maintaining this module. It's great.

thjhoekstra commented 2 years ago

Is there a large difference between V9 and V10 for foundry? I can't recall that V8 to V9 made the modules broken, or people were just fast with updating.

DarioRomano commented 2 years ago

Is there a large difference between V9 and V10 for foundry? I can't recall that V8 to V9 made the modules broken, or people were just fast with updating.

There have been a number of changes regarding the appearance of sheets in V10, therefore this module specifically is affected.

friction1 commented 2 years ago

Does anyone know if the owner has given a timeline for the update? I tried to run a session without this module last night and combat was a disaster. I understand the owner is a volunteer, not trying to rush - just wondering. Thanks for a great module :)

zeel01 commented 2 years ago

I can't really give a timeline, i have very little time to work on these things lately, and there's a lot to do. An update will come, but I can't really guess how soon.

friction1 commented 2 years ago

I can't really give a timeline, i have very little time to work on these things lately, and there's a lot to do. An update will come, but I can't really guess how soon.

Thanks for your reply. Is there anything we can do to support you financially to help prioritize the update? Maybe others would be down to chip in.

davelamorte commented 2 years ago

I can't really give a timeline, i have very little time to work on these things lately, and there's a lot to do. An update will come, but I can't really guess how soon.

Thanks for your reply. Is there anything we can do to support you financially to help prioritize the update? Maybe others would be down to chip in.

Definitely! Well worth it!

Rencos1 commented 2 years ago

I just submitted a pull request that support v10. I didn't test extensively but it seems to work pretty well.

zeel01 commented 2 years ago

I will take a look

ghost commented 2 years ago

Thank you Zeel! I loved using this module for my monsters. It made it so easy to read them and to adjust them :-)

Thanks for trying to help fix it as well Rencos1 :D

friction1 commented 2 years ago

I updated the .json and script files based on Rencos1's pull request in my game and some monsters seem to work fine but several won't open (standard SRD dnd5e mummy stat block for example). Happy to provide a few examples for troubleshooting if it helps.

zeel01 commented 2 years ago

@friction1 If you could provide error messages and statblocks as comments on the pull request that would be helpful.

Additionally, I really want to make at least one release that's cross compatible between v9 and v10 if at all possible, so that's something to keep in mind as well.

friction1 commented 2 years ago

@friction1 If you could provide error messages and statblocks as comments on the pull request that would be helpful.

Additionally, I really want to make at least one release that's cross compatible between v9 and v10 if at all possible, so that's something to keep in mind as well.

Okay I've added some!

ghost commented 2 years ago

Awesome! Thanks for updating this to v10! <3

davelamorte commented 2 years ago

Thank you! Much appreciated!

On Mon, Oct 3, 2022, 09:19 JanHoos @.***> wrote:

Awesome! Thanks for updating this to v10! <3

— Reply to this email directly, view it on GitHub https://github.com/zeel01/MonsterBlocks/issues/198#issuecomment-1265034565, or unsubscribe https://github.com/notifications/unsubscribe-auth/ALBNYKC6OSLB6QOEHKXAET3WBKCGXANCNFSM6AAAAAAQFSUQOM . You are receiving this because you commented.Message ID: @.***>