v11 Support

[evan-rash]

@zeel01 - I think these changes will help support v11. Thanks for making this super awesome module. I use it all the time :)

I tried to get v11 support up and running. It seems like the major changes that had to be addressed were:

• many things referenced data.data.* and needed to be moved to system.*
• the TextEditor call needed to be made non-async
• manifest needed some changes
• bludgeoning / slashing / piercing damage resistances needed a refactor
• something about maximizing led to an infinite loop - I wasn't able to figure out what was going on

[zeel01]

Just wanted to let you know that I do intend to review this. I had some surgery done last week, so I haven't been up to it yet.

[friction1]

@evan-rash I am using these files in Foundry v10 and dnd5e 2.2.1 (except I put the minimum version at 10 instead of 11) and everything works except that Reactions and Bonus don't show up below the headers. Do you know what might have broken that?

[evan-rash]

@friction1 - I didn't actually test it on foundry v10. I'll have to take a look. What you could do is hit F12 and see if there are any errors in the developer console related to monster blocks

[evan-rash]

@friction1 - I just tested on v10 and I see bonus actions and reactions. Can you share a creature from the SRD where you're seeing this issue?

[friction1]

@evan-rash There's a whole host of yellow errors. Maybe it has to do with dnd 2.2.1 vs 2.3? You can't get dnd 2.3 on v10.

[evan-rash]

@friction1 - with dnd5e2.2.1 I am able to see the Shadow's bonus action. Looking at the stack trace you posted, it looks like it's from a mod called dnd5eCharacterActions. If you wanted to test, you could create a brand new empty world on foundryv10 with just dnd2.2.1 and this branch of the mod (I updated minimum version to 10 instead of 11) and see if you still see the issue

[friction1]

@evan-rash here it is with no other modules enabled

[evan-rash]

@zeel01 - hope you're feeling well! Any chance that this will be ready to merge?

[nschoenwald]

I have been testing this and it works great for me on V11! Thanks so much. Hope this can get merged.

[lyzasayshere]

I have been testing this and it works great for me on V11! Thanks so much. Hope this can get merged.

How were you able to get it working?

[Ewokichka]

I followed along and made all the changes you recommended, but still no luck. Though I am a little stumped on the .vscode/launch.json --- where does it go? does the "webRoot" section need to be personalized?

[nschoenwald]

Hi @evan-rash would you consider taking a look at the issue with condition immunities not showing? https://github.com/zeel01/MonsterBlocks/issues/215

Other than that and some very minor stuff, your pull request works perfectly for me in Foundry V11.

[evan-rash]

I was hoping @zeel01 would take this up, but it seems like they've taken a step away from the project

[Ewokichka]

@evan-rash all those changes you did...does someone have to handjam them to make things work? or is there a file that you can post that reflects/contains all the changes you've made to get it working again? I'm very new/illiterate to github.

[evan-rash]

It's all in this PR, so the mod owner could choose to accept them and publish a new version. If that doesn't happen, then I could publish a fork of the mod with the fixes, but I'd prefer not to do that since the original author spent so much work putting this together in the first place!

This is probably my favorite foundry mod and I'd love to see it continue to be supported

[Ewokichka]

Considering they stepped away for medical purposes, I would think they would appreciate the sentiment that someone cared enough to carry the torch while they were away and could take it back upon their return. Or they never come back and all of us look to you as the new leader.

[zeel01]

Sorry everyone for taking so long. I kept meaning to review this and kept not having the time, so I've just merged it as-is and published the release.

[Ewokichka]

Thank you @zeel01 @evan-rash for the update! Monster blocks is probably the most important addon I use; the default interface is not a smooth experience when controlling monsters and this haitus has made me appreciate monsterblocks that much more. Without monsterblocks, I'd be looking for new software to host my games on.