search

zeel01 / MonsterBlocks

A Foundry VTT module to add NPC sheets that faithfully reproduce the appearance of D&D 5e monster statblocks.
29 stars 26 forks source link

Compatibility with dnd5e 3.0 #220

Open nschoenwald opened 9 months ago

nschoenwald commented 9 months ago

Are there any plans to update this module for the new official dnd5e system? This module is still my absolute favorite npc sheet and makes DMing monsters so much easier and intuitive than all other sheets available.

zeel01 commented 9 months ago

It's in the works. See #219.

evan-rash commented 9 months ago

If there's help needed, I might be able to assist

zeel01 commented 9 months ago

@evan-rash I've fixed some of the issues in branch dnd5e-3.0.0, it's rendering now. But there are some other issues like #206, #215, #216, #217, and #218 (maybe #197) that I would like to get in on the same release. I'm happy to review a PR if you want to lend a hand. I should mark some of these help-wanted...

218 in particular needs deeper debugging to find the root cause of. Something is nulling the value at the data model level, which means there's probably an errant mutation somewhere in the sheet, which is tricky to track down. I really want to get that fixed for the next release.

evan-rash commented 9 months ago

I tried loading the 3.0 branch and was running into issues. I didn't spend much time looking into it yet, but just wanted to check that's the right branch to take a look at?

zeel01 commented 9 months ago

The dnd5e-3.0.0 branch is correct. It should render, and shouldn't generate a million warnings. But there are definitely more bugs.

zeel01 commented 8 months ago

Resolved #217, #218, and some other issues. Thanks @LunarShade.

zeel01 commented 8 months ago

See linked PR for issues planned for this release.

LunarShade commented 8 months ago

I've created pull requests for #215, #216 and #191. I've looked at #197 and #206 but have not been able to reproduce them.

197 seems like it might have been patched by a foundry update, but I haven't compared against older versions to confirm whether that's actually the case. Even if it is patched, it might be worth checking for bad formulas on the sheet regardless so that monsterblocks isn't dependent on broken formulas being handled safely in the back-end.

As for #206, I'm not sure what the source of the issue is as I can't reproduce it myself. If you can point me in the right direction I may be able to take another stab at it sometime this week @zeel01.

nschoenwald commented 6 months ago

I am currently using the development branch and it works fine except for the lack of support for enrichers in the monster feature text (see https://github.com/foundryvtt/dnd5e/wiki/Enrichers). Is there any chance of an update addressing that?

zeel01 commented 6 months ago

@nschoenwald That update isn't currently on my radar, currently I'm focused on addressing bugs and major errors. Could you open a separate ticket for that feature request?

nschoenwald commented 6 months ago

@zeel01 Thanks for responding so quickly! I gladly created a ticket: https://github.com/zeel01/MonsterBlocks/issues/230