search

zeel01 / TokenHUDArtButton

A Foundry VTT module that adds a button to the token HUD that opens the target actor's artwork.
MIT License
6 stars 5 forks source link

Show token art no longer works in Foundry V10 #20

Open vgeirnaert opened 2 years ago

vgeirnaert commented 2 years ago

As per comment. Show token art no longer works in V10. Show actor art still works.

vgeirnaert commented 2 years ago

Provided a fix for it in this PR: https://github.com/zeel01/TokenHUDArtButton/pull/22

Kerdude commented 2 years ago

Is this going to be merged or? Seems like a fix was provided a month ago

lucasmiranda2711 commented 1 year ago

Confirmed working with the PR by vgeirnaert

KellethDregar commented 1 year ago

@zeel01 Confirmed working here as well.

sharkbruhaha commented 1 year ago

thanks for the patched fork @vgeirnaert ! Can you do a release of it though?

DrMcCoy commented 1 year ago

Thanks for the patches @vgeirnaert!

Seems like @zeel01 abandoned this module, though, it seems :/. I emailed them two weeks ago, too, and as of yet, haven't received any reply.

Maybe the time for a more "hostile" (for the lack of a better word) fork has come? As in, make your fork repository more standalone-ish, rename it slightly ("Show Art 2"? "Show Art NG"?) and register for a module spot on the FoundryVTT, etc. That way, people can actually install this module again as normal, instead of having to manually. Provided you have time and interest in maintaining it from now on, that is.

If you don't, I'm offering to do that instead. I'm already maintaining a fork of Bullseye, which I named Bullseye NG (yeah, I know, very creative) when the original author just vanished and deleted the original repository one day. I'm however not necessarily a JavaScript luminary or webdev person (I'm more at home with C/C++), so I'm just stumbling my way around here.

So while I can do the origanisatorial stuff of merging PRs, etc., there's probably not much in me regarding actual new features. Because of this, I'd be very happy to just have you take the lead if you want.

Either way, feel free to throw in other suggestions as well. Or @zeel01, if you're still willing to maintain this module, this conversation would be moot.

zeel01 commented 1 year ago

Sorry about that guys, I have had very little time for Foundry or D&D for a while. I have merged the PRs that should get it working in v10.

DrMcCoy commented 1 year ago

Thank you!