search

zeelot / kohana-yform

Form Generation =(
15 stars 2 forks source link

Radio groups should not use legend/fieldset #28

Open alanhogan opened 14 years ago

alanhogan commented 14 years ago

It’s silly and can lead to a bold or oddly styled label for the group. "Legitimate" fieldset/legend uses should not be sharing styles with any old set of radio buttons.

zeelot commented 14 years ago

what do you suggest?

alanhogan commented 14 years ago

Just a div with a sensible class.

zeelot commented 14 years ago

and what is the label? a header? paragraph? just a div with text? fieldset+legend seems like the best implementation to me

alanhogan commented 14 years ago

Want to reiterate my strong believe that legend+fieldset is inappropriate. It looks terrible and common associated styles are not appropriate.

Please just use a div or span for the label, with an appropriate class like yform-radiogroup-label

Eventually I will have to make this change myself if no one else does, for Nestablish, where it is affecting views.

jeremeamia commented 14 years ago

Hey, I agree with Alan. Radio or Checkbox groups should not use fieldset and legend. One reason because legends do not wrap when they are too long for the space. I changed them on a project at work to use divs like the other yform elements.

zeelot commented 14 years ago

you probably shouldn't link to private repositories

jeremeamia commented 14 years ago

That's an excellent point. Sometimes I forget GitHub is not work exclusive.