search

zeenlym / docker-mariadb-backup

Docker image for backing up mariadb
GNU General Public License v3.0
6 stars 5 forks source link

Restore fails to extract 7z archive correctly #2

Open joelbernstein opened 7 years ago

joelbernstein commented 7 years ago

I have opened a PR with a fix. Essentially, the shell redirection in the 7z extract commandline has spaces where it should not have. 2 > wherever is not the same as 2>wherever.

joelbernstein commented 7 years ago 
root@node48605-ipso-lebanon:~# restore
Choose backup to restore
   date                size       md5
 0 2017-09-04-23:12:00 2.9KiB     OK
 1 2017-09-04-12:33:12 2.9KiB     OK
 2 2017-09-04-18:12:00 0.0B       ABS
 3 2017-09-05-00:12:00 2.9KiB     OK
 4 2017-09-04-19:12:00 2.9KiB     OK
 5 2017-09-05-15:12:00 3.0KiB     OK
 6 2017-09-04-20:12:00 2.9KiB     OK
 7 2017-09-05-01:12:00 2.9KiB     OK
 8 2017-09-04-12:30:12 2.9KiB     OK
 9 2017-09-05-04:12:00 2.9KiB     OK
10 2017-09-05-07:12:00 2.9KiB     OK
11 2017-09-05-18:12:00 3.0KiB     OK
12 2017-09-05-20:12:00 3.0KiB     OK
13 2017-09-05-08:12:00 2.9KiB     OK
14 2017-09-04-16:12:00 2.9KiB     OK
15 2017-09-05-03:12:00 2.9KiB     OK
16 2017-09-05-14:12:00 3.0KiB     OK
17 2017-09-05-09:12:00 2.9KiB     OK
18 2017-09-05-06:12:00 2.9KiB     OK
19 2017-09-04-13:12:00 2.9KiB     OK
20 2017-09-05-12:12:00 3.0KiB     OK
21 2017-09-05-23:12:00 3.0KiB     OK
22 2017-09-04-17:12:00 2.9KiB     OK
23 2017-09-05-11:12:00 2.9KiB     OK
24 2017-09-05-10:12:00 2.9KiB     OK
25 2017-09-04-15:12:00 2.9KiB     OK
26 2017-09-04-14:12:00 2.9KiB     OK
27 2017-09-05-13:12:00 3.0KiB     OK
28 2017-09-04-12:27:12 2.9KiB     OK
29 2017-09-05-02:12:00 2.9KiB     OK
30 2017-09-05-17:12:00 3.0KiB     OK
31 2017-09-04-12:36:12 2.9KiB     OK
32 2017-09-05-05:12:00 2.9KiB     OK
33 2017-09-04-22:12:00 2.9KiB     OK
34 2017-09-05-19:12:00 3.0KiB     OK
35 2017-09-05-21:12:00 3.0KiB     OK
36 2017-09-04-21:12:00 2.9KiB     OK
37 2017-09-05-22:12:00 3.0KiB     OK
38 2017-09-05-16:12:00 3.0KiB     OK
q - quit
Which one do you want to restore ? [0]:37

7-Zip (A) [64] 9.20  Copyright (c) 1999-2010 Igor Pavlov  2010-11-18
p7zip Version 9.20 (locale=C,Utf16=off,HugeFiles=on,8 CPUs)

Processing archive: /backup/mysqldump_ipso_2017-09-05-22-12-00.sql.7z

No files to process

Files: 0
Size:       0
Compressed: 3099
joelbernstein commented 7 years ago

After some investigation with the dry run --simule arg, I found that the "no files to process" message is because 7zr thinks it is being told to extract a file called 2. This is due to the command line construction with the shell redirection of stdout being incorrectly spaced.

Please merge and release the tiny PR I have made.