zeeshanlakhani / schema-gen

Turn Prismatic schemas into generated data.
Eclipse Public License 1.0
34 stars 3 forks source link

thank you to @gfredericks for pointing out the lame #11

Closed zeeshanlakhani closed 9 years ago

gfredericks commented 9 years ago

I think you can keep using the or to do what you added the if-let to do -- looks like in the new version the or is now superfluous?

gfredericks commented 9 years ago

I.e., I would change it to (or (schema->gen* e) (throw ...))

zeeshanlakhani commented 9 years ago

@gfredericks good point and i just saw how dumb i was being. this is not erlang haha.

zeeshanlakhani commented 9 years ago

@gfredericks times when you forget that upside-down carat means or. pretty symbols.

gfredericks commented 9 years ago

oh no now the indentation is off :astonished:

zeeshanlakhani commented 9 years ago

@gfredericks hmm, emacs mode is telling me otherwise, hmm.

zeeshanlakhani commented 9 years ago

ah. turned off pretty symbols. derpy derp.

gfredericks commented 9 years ago

what did you tell your emacs to rewrite "or" as "^"?

you monster

gfredericks commented 9 years ago

Now the two args to ex-info aren't lined up

zeeshanlakhani commented 9 years ago

@gfredericks i am... yeah fixing now. cold hands.

gfredericks commented 9 years ago

did you tell emacs to rewrite ex-info as cold-hands?

zeeshanlakhani commented 9 years ago

If only Github knew how great "^" is.

zeeshanlakhani commented 9 years ago

@gfredericks if you're cold hands cool i'll merge and make a new point version w/ test.chuck.

zeeshanlakhani commented 9 years ago

@gfredericks tho... should use type instead of class.

gfredericks commented 9 years ago

w00t :+1:

also :+1: for new release; we've been using fork releases for a while

zeeshanlakhani commented 9 years ago

@gfredericks done!.