search

zeevl / connect-include

A node connect middleware component to allow for SSI-style includes
5 stars 5 forks source link

/ route doesn't include with Grunt connect #1

Closed academo closed 3 years ago

academo commented 11 years ago

Using Connect with grunt I access to my project index with some url like:

localhost:9000

When I use this URL the include doesn't work (just show the html comment), I must use

localhost:9000/index.html

and then It works.

I didn't test the issue with pure connect

Thanks for this great work!

jraller commented 10 years ago

Using grunt serve with http://localhost:9000/page.html works, but it does not work with http://localhost:9000/page.html?id=1.

It looks like modifying line 11 to remove the $ after \.html will allow it to process any url that includes .html instead of only those that end with .html. A more robust solution might check that what follows the .html is (?:#|\?)? one of either the start of an anchor or a search.

npmjs.org is still listing version 0.2.1 even though it looks like version 0.2.2 is current.

schmod commented 10 years ago

Same issue here..

zeevl commented 9 years ago

@jraller this was fixed in your PR, right?

jraller commented 9 years ago

I believe so.