zefchain / serde-reflection

Rust libraries and tools to help with interoperability and testing of serialization formats based on Serde.
Apache License 2.0
139 stars 26 forks source link

update ci workflow #28

Closed kturney closed 1 year ago

kturney commented 1 year ago

Summary

Revamps and fixes CI workflow.

Updates

Potential shortcomings

Misc

Warnings during tests indicate that .Net@2.1 is no longer supported. We could use this opportunity to bump the minimum support versions of different supported runtimes.

ma2bd commented 1 year ago

@kturney Thanks for the PR. This looks great! My only ask is that we keep using the pinned version of Rust (aka the one from rust-toolchain) in CI. Otherwise, I believe CI may break (typically clippy) whenever ubuntu-latest changes.

kturney commented 1 year ago

Hi @ma2bd, thanks for the quick review! Since the rust-toolchain.toml is there, CI is currently pinned to using 1.60.0 for everything. And it's my understanding that will only change if we update the toolchain in the rust-toolchain.toml. Is that not correct?

Are you wanting me to change every use of cargo to cargo +1.60.0 to be extra certain?