Closed kturney closed 1 year ago
@kturney Thanks for the PR. This looks great! My only ask is that we keep using the pinned version of Rust (aka the one from rust-toolchain) in CI. Otherwise, I believe CI may break (typically clippy) whenever ubuntu-latest
changes.
Hi @ma2bd, thanks for the quick review!
Since the rust-toolchain.toml
is there, CI is currently pinned to using 1.60.0 for everything.
And it's my understanding that will only change if we update the toolchain
in the rust-toolchain.toml
.
Is that not correct?
Are you wanting me to change every use of cargo
to cargo +1.60.0
to be extra certain?
Summary
Revamps and fixes CI workflow.
Updates
rust-toolchain
to newerrust-toolchain.toml
rustup
included inubuntu-latest
to install the toolchain specified inrust-toolchain.toml
rust-analyzer
CI workflowapt-get
directlyPotential shortcomings
std::numeric_limits
to fix cpp tests, matching fix found here. I'm not sure if that is considered a breaking change.Misc
Warnings during tests indicate that .Net@2.1 is no longer supported. We could use this opportunity to bump the minimum support versions of different supported runtimes.