zefei / vim-wintabs

Modern buffer manager for Vim
MIT License
325 stars 25 forks source link

Fixes status bar highlighting in statusline mode #34

Closed theethernaut closed 5 years ago

theethernaut commented 6 years ago

Added a g:wintabs_ui_inactive_higroup property which fixes the problem of no highlighting being set on the inactive buffer elements.

Before: screenshot from 2018-05-20 19-46-23

After: screenshot from 2018-05-20 19-48-53

zefei commented 6 years ago

Hey @ajsantander thanks for the PR! The screenshot you have looks like a bug to me, since the inactive buffers have different highlight groups. The intended highlighting is that all inactive buffers and empty spaces use default statusline highlight group "StatusLine". But it doesn't seem to be the case in your screenshot.

I'm not going to merge this PR because I feel it doesn't fix the real bug. I'll investigate this issue and see what I can do. Meanwhile, can you help me by post a minimal repro vimrc (small vimrc that can reproduce this bug)?