search

zeforgezenica / busez

App for tracking bus transit data in a city.
https://kadjebus.zeforge.ba
GNU General Public License v3.0
20 stars 42 forks source link

Add Multi-Language Support to Enhance User Experience #98

Open abdeLKabir-56 opened 1 month ago

abdeLKabir-56 commented 1 month ago

add multi-language support to our app! This will help users feel more comfortable and improve their experience.

khd33j commented 1 month ago

Adding English first would be ideal since it's more internationally accessible. This issue should be a priority if you need more contributors.

bambooch commented 1 month ago

ah yes you're totally right, I was planning on creating this issue as well..

We never imagined an international scale TBH and now we have a few things already underway by several contributors (refactoring and new feature integration) but the source code is all in english so should be understandable enough.

There are only some 5-10 strings that need to be localized but nevertheless it is important

bambooch commented 1 month ago

you're free to give it a go if you want @khd33j @abdeLKabir-56 gotta do some git gimnastics right now 😆

namansharma3007 commented 1 month ago

I can go for it. Please assign it to me

bambooch commented 1 month ago

hi @namansharma3007 thanks! I've assigned you the issue

Scharfcsh commented 1 month ago

hi @bambooch can I work on this issue too!?

alempasalic commented 1 month ago

hi @bambooch can I work on this issue too!?

Hey @Scharfcsh,

Before proceeding with assigning you to a new issue, could you please address the following points identified in PR #110?

  1. This review comment highlights important feedback, such as:

    • The need to address incomplete light mode integration, especially for components like the footer and the date picker
    • The suggestion to create a new branch on your fork when opening a PR to allow maintainers and other contributors to add commits.
    • Opening separate PRs for different issues to facilitate more manageable reviews and merges.

  2. In this comment, it was noted that the additions to the .gitignore file are unnecessary due to line 30.

  3. This comment mentions that the changes in frontend/src/app/page.tsx are related to code formatting. Ideally, such changes should be in a separate commit since they are not part of the icon change. However, no changes are needed here.

  4. In this comment, an extra line was added in frontend/src/app/layout.tsx without any explanation.

Please address these issues first. If you need any help or have any questions, feel free to reach out.

Thank you for your contributions!

Scharfcsh commented 1 month ago

hi @bambooch can I work on this issue too!?

Hey @Scharfcsh,

Before proceeding with assigning you to a new issue, could you please address the following points identified in PR #110?

  1. This review comment highlights important feedback, such as:
  • The need to address incomplete light mode integration, especially for components like the footer and the date picker
  • The suggestion to create a new branch on your fork when opening a PR to allow maintainers and other contributors to add commits.
  • Opening separate PRs for different issues to facilitate more manageable reviews and merges.
  1. In this comment, it was noted that the additions to the .gitignore file are unnecessary due to line 30.
  2. This comment mentions that the changes in frontend/src/app/page.tsx are related to code formatting. Ideally, such changes should be in a separate commit since they are not part of the icon change. However, no changes are needed here.
  3. In this comment, an extra line was added in frontend/src/app/layout.tsx without any explanation.

Please address these issues first. If you need any help or have any questions, feel free to reach out.

Thank you for your contributions!

I am closing that PR, since there are too many issues.