fix(316, 326, 256, 252, 243, and more): provide color-picker service in root - Githubissues

zefoy / ngx-color-picker

Color picker widget for the Angular (version 2 and newer)

MIT License

457 stars 143 forks source link

fix(316, 326, 256, 252, 243, and more): provide color-picker service in root #351

Closed sdedieu closed 4 months ago

sdedieu commented 9 months ago

Does the ColorPickerService really need to have different instances ? If not, provide it in root will solve a lot of issues.

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

No value is set in the @Injectable() decorator.

Issue Number: fixes #316, #326, #256, #252, #243

What is the new behavior?

@Injectable decorator is now providedIn: 'root'

Does this PR introduce a breaking change?

[ ] Yes
[x] No