zegervdv / homebrew-zathura

Homebrew formulae to build Zathura on Mac OS X
535 stars 42 forks source link

Install from `--HEAD` fails on macOS Sonoma 14.5 #127

Open mattf1n opened 2 months ago

mattf1n commented 2 months ago
mattf1n@Matthews-MacBook-Pro ~ % brew install zathura --HEAD

==> Fetching zegervdv/zathura/zathura
==> Cloning https://github.com/pwmt/zathura.git
Updating /Users/mattf1n/Library/Caches/Homebrew/zathura--git
==> Checking out branch develop
Already on 'develop'
Your branch is up to date with 'origin/develop'.
HEAD is now at 7d8b807 remove is_valid_path, an unused variable
==> Installing zathura from zegervdv/zathura
==> meson ..
==> ninja
Last 15 lines from /Users/mattf1n/Library/Logs/Homebrew/zathura/02.ninja:
clang -Izathura.p -I. -I.. -I/opt/homebrew/opt/libpng/include/libpng16 -I/opt/homebrew/opt/freetype/include/freetype2 -I/opt/homebrew/Cellar/fontconfig/2.15.0/include -I/opt/homebrew/Cellar/pcre2/10.43/include -I/opt/homebrew/Cellar/xz/5.4.6/include -I/opt/homebrew/Cellar/glib/2.80.3/include/gio-unix-2.0 -I/opt/homebrew/Cellar/glib/2.80.3/include -I/opt/homebrew/Cellar/glib/2.80.3/include/glib-2.0 -I/opt/homebrew/Cellar/glib/2.80.3/lib/glib-2.0/include -I/opt/homebrew/opt/gettext/include -I/opt/homebrew/Cellar/libxau/1.0.11/include -I/opt/homebrew/Cellar/libxdmcp/1.1.5/include -I/opt/homebrew/Cellar/libxcb/1.17.0/include -I/opt/homebrew/Cellar/libx11/1.8.9/include -I/opt/homebrew/Cellar/libxext/1.3.6/include -I/opt/homebrew/Cellar/libxrender/0.9.11/include -I/opt/homebrew/Cellar/pixman/0.42.2/include/pixman-1 -I/opt/homebrew/Cellar/cairo/1.18.0/include -I/opt/homebrew/Cellar/cairo/1.18.0/include/cairo -I/opt/homebrew/Cellar/jpeg-turbo/3.0.3/include -I/opt/homebrew/opt/zstd/include -I/opt/homebrew/Cellar/libtiff/4.6.0/include -I/opt/homebrew/Cellar/gdk-pixbuf/2.42.12/include/gdk-pixbuf-2.0 -I/opt/homebrew/Cellar/fribidi/1.0.15/include/fribidi -I/opt/homebrew/Cellar/graphite2/1.3.14/include -I/opt/homebrew/Cellar/harfbuzz/8.5.0/include/harfbuzz -I/opt/homebrew/Cellar/pango/1.54.0/include/pango-1.0 -I/opt/homebrew/Cellar/at-spi2-core/2.52.0/include/atk-1.0 -I/opt/homebrew/Cellar/libepoxy/1.5.10/include -I/opt/homebrew/Cellar/gtk+3/3.24.42/include/gtk-3.0 -I/opt/homebrew/Cellar/json-glib/1.8.0/include/json-glib-1.0 -I/opt/homebrew/Cellar/girara/HEAD-23b4ed7/include -I/opt/homebrew/Cellar/xorgproto/2024.1/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX14.sdk/usr/include/ffi -I/opt/homebrew/Cellar/libmagic/5.45/include -I/opt/homebrew/opt/sqlite/include -I/opt/homebrew/Cellar/gtk-mac-integration/3.0.1_1/include/gtkmacintegration -fdiagnostics-color=always -Wall -Winvalid-pch -Wextra -Wpedantic -std=c17 -O3 -DMAC_INTEGRATION '-DGETTEXT_PACKAGE="zathura"' '-DLOCALEDIR="/opt/homebrew/Cellar/zathura/HEAD-7d8b807/share/locale"' '-DZATHURA_PLUGINDIR="/opt/homebrew/Cellar/zathura/HEAD-7d8b807/lib/zathura"' -D_DEFAULT_SOURCE -DGTKOSXAPPLICATION -Werror=implicit-function-declaration -Werror=vla -fvisibility=hidden -Werror=int-conversion -MD -MQ zathura.p/zathura_main.c.o -MF zathura.p/zathura_main.c.o.d -o zathura.p/zathura_main.c.o -c ../zathura/main.c
../zathura/main.c:287:7: error: call to undeclared function 'girara_warn'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
      girara_warn("TestIntegration Error! Bundle has ID %s", id);
      ^
1 error generated.
[14/67] Compiling C object libzathura.a.p/zathura_adjustment.c.o
[15/67] Compiling C object libzathura.a.p/zathura_database.c.o
[16/67] Compiling C object libzathura.a.p/zathura_commands.c.o
[17/67] Compiling C object libzathura.a.p/zathura_completion.c.o
[18/67] Compiling C object libzathura.a.p/zathura_bookmarks.c.o
[19/67] Compiling C object libzathura.a.p/zathura_config.c.o
[20/67] Compiling C object libzathura.a.p/zathura_callbacks.c.o
[21/67] Compiling C object libzathura.a.p/zathura_database-sqlite.c.o
[22/67] Compiling C object libzathura.a.p/zathura_dbus-interface.c.o
ninja: build stopped: subcommand failed.
vxnuaj commented 2 months ago

Getting the same errors as well,

Last 15 lines from /Users/juanvera/Library/Logs/Homebrew/zathura/02.ninja:
  girara_argument_t arg = { GIRARA_HIDE, NULL };
                            ^~~~~~~~~~~
../zathura/shortcuts.c:1414:42: error: incompatible pointer to integer conversion initializing 'int' with an expression of type 'void *' [-Wint-conversion]
  girara_argument_t arg = { GIRARA_HIDE, NULL };
                                         ^~~~
/Library/Developer/CommandLineTools/usr/lib/clang/15.0.0/include/stddef.h:89:16: note: expanded from macro 'NULL'
#  define NULL ((void*)0)
               ^~~~~~~~~~
6 errors generated.
[37/68] Compiling C object libzathura.a.p/zathura_synctex.c.o
[38/68] Compiling C object libzathura.a.p/zathura_render.c.o
[39/68] Compiling C object libzathura.a.p/zathura_types.c.o
[40/68] Compiling C object libzathura.a.p/zathura_utils.c.o
[41/68] Compiling C object libzathura.a.p/zathura_zathura.c.o
ninja: build stopped: subcommand failed.
vxnuaj commented 2 months ago

if you install poppler without the osx native integration, it works fine for me. i'm on sonoma 14.1 btw.

mattf1n commented 2 months ago

Yes, installing not from head works just fine, but I was hoping for the native integration :)

squingo44 commented 1 month ago

if you install poppler without the osx native integration, it works fine for me. i'm on sonoma 14.1 btw.

How do I install poppler without the osx native integration please?

mattf1n commented 1 month ago

You can follow the steps in the README.md installation steps. It should work so long as you didn't brew install zathura with the --HEAD flag.