zegervdv / homebrew-zathura

Homebrew formulae to build Zathura on Mac OS X
548 stars 43 forks source link

zathura 0.3.9 is released #22

Closed phye closed 6 years ago

phye commented 6 years ago

Can you update your repo to point to the latest source?

Thanks

phye commented 6 years ago

Just tried myself, found out that zathura authors are switching from Makefile to meson, possibly for all other dependent components like girara .etc.

As 0.3.9 ships with HiDPI support, this is really a tremendous upgrade.

zegervdv commented 6 years ago

I managed to update girara and zathura to the latest versions (after some fooling around with the meson tool) but I can't get the plugins to work yet.

You may need to manually install meson from source because of mesonbuild/meson#3493:

brew install --HEAD meson

I need to figure out a way to cleanly install the plugins to the right directory without violating the sandboxing.

zegervdv commented 6 years ago

Found a workaround for the zathura-pdf-poppler plugin but it still needs some manual action afterwards. I will update the other plugins later this week.

phye commented 6 years ago

Just FYI, I've managed to build 0.3.9 zathura (and girara, and zathura-pdf-poppler to their corresponding latest version) without homebrew, with several manual patch to the meson configuration file (mainly to remove libm dependency as it is already in glibc in macOS).

However, I would still be very anxious for your formulae for zathura as managing softwares by homebrew is far more clear than maintaining them by myself :)

Thanks for your effort!

zegervdv commented 6 years ago

I’ve updated them yesterday so you should be able to install them via homebrew now.

phye commented 6 years ago

Just tried your formulae, however, brew install failed in Installing files.

Not sure if you're familiar with meson, but here's the logs if you happen to:

[0/1] Installing files.
Installing data/org.pwmt.zathura.desktop to /usr/local/Cellar/zathura/0.3.9/share/applications/org.pwmt.zathura.desktop
Traceback (most recent call last):
  File "/usr/local/Cellar/meson/0.46.0/libexec/bin/meson", line 26, in <module>
    sys.exit(main())
  File "/usr/local/Cellar/meson/0.46.0/libexec/bin/meson", line 23, in main
    return mesonmain.run(sys.argv[1:], launcher)
  File "/usr/local/lib/python3.6/site-packages/mesonbuild/mesonmain.py", line 308, in run
    sys.exit(run_script_command(args[1:]))
  File "/usr/local/lib/python3.6/site-packages/mesonbuild/mesonmain.py", line 257, in run_script_command
    return cmdfunc(cmdargs)
  File "/usr/local/lib/python3.6/site-packages/mesonbuild/scripts/meson_install.py", line 390, in run
    do_install(datafilename)
  File "/usr/local/lib/python3.6/site-packages/mesonbuild/scripts/meson_install.py", line 216, in do_install
    install_targets(d)
  File "/usr/local/lib/python3.6/site-packages/mesonbuild/scripts/meson_install.py", line 371, in install_targets
    depfixer.fix_rpath(outname, install_rpath, False)                                                                                    File "/usr/local/lib/python3.6/site-packages/mesonbuild/scripts/depfixer.py", line 391, in fix_rpath
    fix_darwin(fname, new_rpath)
  File "/usr/local/lib/python3.6/site-packages/mesonbuild/scripts/depfixer.py", line 376, in fix_darwin
    subprocess.check_call(['install_name_tool', '-add_rpath', new_rpath, fname])
  File "/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/subprocess.py", line 286, in check_call
    retcode = call(*popenargs, **kwargs)                                                                                                 File "/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/subprocess.py", line 267, in call            with Popen(*popenargs, **kwargs) as p:
  File "/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/subprocess.py", line 709, in __init__
    restore_signals, start_new_session)
  File "/usr/local/Cellar/python/3.6.5/Frameworks/Python.framework/Versions/3.6/lib/python3.6/subprocess.py", line 1275, in _execute_child
    restore_signals, start_new_session, preexec_fn)
TypeError: expected str, bytes or os.PathLike object, not NoneType
FAILED: meson-install
/usr/local/opt/python/bin/python3.6 /usr/local/Cellar/meson/0.46.0/libexec/bin/meson --internal install /private/tmp/zathura-20180502-2042-udxdi3/zathura-0.3.9/build/meson-private/install.dat
ninja: build stopped: subcommand failed.
phye commented 6 years ago

Sorry, I forgot to install the correct meson, the logs above were due to that I was using the meson installed via brew install meson manually back to weeks ago when I was building them from source.

After removing meson and install the correct one (brew install --HEAD meson), I can build zathura now.

Thanks.

zegervdv commented 6 years ago

Thanks for letting me know. I’ll close the issue but if something’s still not working feel free to reopen it.