search

zegervdv / homebrew-zathura

Homebrew formulae to build Zathura on Mac OS X
548 stars 43 forks source link

Failed to install zathura-djvu after upgrading to zathura 0.3.9 #25

Closed howsiwei closed 6 years ago

howsiwei commented 6 years ago

On MacOS High Sierra 10.13.4.

==> Installing zathura-djvu from zegervdv/zathura
==> Downloading https://pwmt.org/projects/zathura-djvu/download/zathura-djvu-0.2.6.tar.gz
Already downloaded: /Users/hsw/Library/Caches/Homebrew/zathura-djvu-0.2.6.tar.gz
==> Downloading https://github.com/zegervdv/homebrew-zathura/raw/master/zathura-djvu-patch-Makefile.diff
Already downloaded: /Users/hsw/Library/Caches/Homebrew/zathura-djvu--patch-e26dbf219c58e1d3537ac2a478b0275ea4d50b9ccea05005d93f297f901da751.diff
==> Downloading https://github.com/zegervdv/homebrew-zathura/raw/master/zathura-djvu-patch-config.mk.diff
Already downloaded: /Users/hsw/Library/Caches/Homebrew/zathura-djvu--patch-1528cf683de8c6af2425c9f1ec062acfddd5e558f8017a4c50f679e09aaac0c8.diff
==> Patching
==> Applying zathura-djvu-patch-Makefile.diff
patching file Makefile
==> Applying zathura-djvu-patch-config.mk.diff
patching file config.mk
Hunk #1 succeeded at 46 with fuzz 2 (offset 3 lines).
==> make install
Last 15 lines from /Users/hsw/Library/Logs/Homebrew/zathura-djvu/01.make:
CC page-text.c
djvu.c:40:3: error: expected parameter declarator
  "djvu",
  ^
djvu.c:40:3: error: expected ')'
djvu.c:39:24: note: to match this '('
ZATHURA_PLUGIN_REGISTER(
                       ^
djvu.c:46:2: error: expected ';' after top level declarator
)
 ^
 ;
3 errors generated.
make: *** [djvu.o] Error 1
make: *** Waiting for unfinished jobs....
zegervdv commented 6 years ago

I've only updated the zathura-pdf-poppler plugin at this moment. I'll try to get the other ones done today.

zegervdv commented 6 years ago

I've updated the plugin to the latest version. Let me know if you still have issues.

howsiwei commented 6 years ago

Thanks! It works now.

gennaro-tedesco commented 3 years ago

I've updated the plugin to the latest version. Let me know if you still have issues.

What is the preferred way to install the djvu plugin, then? I have tried the code shown here but it seems to do nothing; likewise, I cannot find corresponding instructions in the README: do we have a homebrew formula for it?

zegervdv commented 3 years ago

I don't understand your question?

You can just install it via brew install zathura-djvu and follow the after install instructions printed in the terminal.

gennaro-tedesco commented 3 years ago

You can just install it via brew install zathura-djvu

this was the formula I was referring to, thanks for clarifying (it is not indicated in the README, is it?). It is all clear now :)