zegervdv / homebrew-zathura

Homebrew formulae to build Zathura on Mac OS X
538 stars 41 forks source link

SyncTeX version confusion #95

Open Vectornaut opened 1 year ago

Vectornaut commented 1 year ago

I'm using depends_on "zegervdv/zathura/synctex" in a Homebrew formula that builds another program (Gummi) from source. The SyncTeX tap seems to say it's at version 1, but act like it's at version 2, causing the build to fail unless I manually change the result of the version check. I'm raising the issue here in case it's coming from this package, rather than from Gummi.

zegervdv commented 1 year ago

What do you mean by version 2?

I'm using synctex from the GitHub repo at this revision: https://github.com/jlaurens/synctex/tree/a256d4835b7df2a0472cfa3d557af73a1b83f076

The version header file indicates it is 1.22. I have no idea about the content of the source files.

Vectornaut commented 1 year ago

What do you mean by version 2?

Gummi has a configuration switch that triggers when SyncTeX is at version 1.99 or below (version 1). It seems to accommodate breaking changes that appear in versions 2.00 and higher. For example, it changes the expected signatures of some SyncTeX functions. When I build Gummi using the SyncTeX tap in this repository, I get signature errors unless I manually set the switch as though SyncTeX were at version 2.00 or higher.

zegervdv commented 1 year ago

I've just provided a way to compile it, but I don't know much about the project itself. I'm not setting any defines for the compile, so I wouldn't know how it switched to version 2.

You could ask on the linked repo if they have an idea? If I have to change something to the formula, let me know.