search

zegervdv / hubot-ms-teams

Microsoft Teams adapter for hubot
4 stars 2 forks source link

Link to Custom Bots is broken in README.md #2

Closed GregHarriett closed 6 years ago

GregHarriett commented 6 years ago

Noticed that the "Custom Bot" link was no longer valid. I did a little looking around and found a number of alternatives. The best looks to be this - https://docs.microsoft.com/en-us/microsoftteams/platform/concepts/bots/bots-conversations#replying-to-messages

Fixed it in the file but found I could not do a pull request to your repo.

BTW, thank you for trying to put something together on Hubot in MS Teams. My group is looking to do this and may move forward with what you have here as a guidepost.

zegervdv commented 6 years ago

Weird the pull request doesn’t work. What’s the issue you’re seeing?

Sadly, due to our closed network I can’t get the other way to work. I’m hoping the the “on premise” bot system will be implemented soon.

Anyway, if you have any progress feel free to do a pull request (if it works)

GregHarriett commented 6 years ago

On the pull request this is the message I get back. image

zegervdv commented 6 years ago

Did you do a fork of the github page? You can’t push directly to my repo. You need to make your own fork, push your changes to it and then raise the pull request from there.

GregHarriett commented 6 years ago

No I just did a clone. I'll try forking it.

GregHarriett commented 6 years ago

Ok, looks like forking it did the trick. If it's open source I would not think that forking to my user would be needed. Not sure I understand why using a clone doesn't allow the pull request. Likely my ignorance.

zegervdv commented 6 years ago

It’s to give the owner some control over what gets added I guess. You can find some more info in the github help pages: https://help.github.com/articles/about-pull-requests/

Anyway thanks for your fix!