search

zegl / kube-score

Kubernetes object analysis with recommendations for improved reliability and security. kube-score actively prevents downtime and bugs in your Kubernetes YAML and Charts. Static code analysis for Kubernetes.
https://kube-score.com
MIT License
2.74k stars 176 forks source link

Helm V3 Support #345

Closed doughoke closed 3 years ago

doughoke commented 3 years ago

Which version of kube-score are you using?

kube-score version: 1.10.0

What did you do?

Attempting to helm template per spec on Readme in an automated pipeline that can run your docker image against a helm/values pairing for notification of best practices prior to helm install or kubectl apply .

What did you expect to see? It work on a helmV3 chart when I run template. One or two helm template switches in V2 helm cli are different or removed.

The ability to run helm template however most charts have flipped to v3 and therefore incompatibility issues could arise. What did you see instead?

A description of what happened, include logs and program output No logs just a request...

Should I do a pull request and update your helm.Dockerfile or create a new one helmv3.Docerfile. Impact would be that existing users could be impacted on just updating original. Second option will most likely cause you to have another docker build/tag line. Either way, you may want to deprecate helm v2 support at some point.

I have a fork already just let me know which direction you would like. I can get the dockerfile done rather quickly as it is just find/replace.

zegl commented 3 years ago

Hey @doughoke,

Thanks for taking your time to think about this. While I agree that support for Helm 2 likely should be deprecated at some point, I don't think that that time is now (I don't have any data to back this claim, it's just my gut feeling). Adding a new helm3.Dockefile sounds like a great way to get this started, without having to worry about creating any breaking changes.

doughoke commented 3 years ago

Thanks for the follow up. Pull request submitted https://github.com/zegl/kube-score/pull/346

doughoke commented 3 years ago

Closing with merge of above PR ^^^