Closed kmarteaux closed 2 years ago
Hey, thanks for contributing! This is looking really good, just some small tweaks:
1) Could we split the test so that the test for checking that the requirements equal the limits is in a separate (and optional) test. See score/container/container.go
for how it's done for the other limits.
2) Could this code be moved to score/container
? I like the structure where all tests are structured after the Type that it's testing.
Also, something is off with the test, it's setting the flag to test an optional test that doesn't seem to exist.
Yes, no problem. I will make the suggested changes and resubmit.
I'm going to close this PR, rebased my commits and then redo the PR.