Closed kmarteaux closed 2 years ago
Refactored the original implementation - moved the new checks to score/container.go and the associated tests to score/score_test.go. Split the resource checks into default (are they set) and optional (are they equal) as previously recommended. Removed the separate score/ephemeralstorage/ephemeralstorage.go and score/ephemeralstorage_test.go files. Updated score.go to remove ref to deleted files.
Thanks! Looks great 👍 , there's just one test case (the happy path) that isn't tested. Update the PR with that, and we're ready to ship!
Build succeeded: