zegl / kube-score

Kubernetes object analysis with recommendations for improved reliability and security. kube-score actively prevents downtime and bugs in your Kubernetes YAML and Charts. Static code analysis for Kubernetes.
https://kube-score.com
MIT License
2.67k stars 175 forks source link

Documentation on the use of livenessProbe #522

Open binboum opened 1 year ago

binboum commented 1 year ago

Hello :)

We recently used within the company in which I work kube-score in order to improve the quality of our deliverables.

I noticed that on the livenessProbe level documentation : https://github.com/zegl/kube-score/blob/master/README_PROBES.md#livenessprobe

There were these recommendations :

kube-score recommends:

I don't know how the message is interpreted in general. However, I find this message ambiguous, and in my opinion, It would be a little more educational by encouraging the user to understand his use and it is he who will make the choice knowingly.

I would have preferred a more educational twist like :

image

Here : https://github.com/kubernetes/website/issues/16607#issuecomment-536781619

PR discussion : https://github.com/kubernetes/website/pull/39930