zegl / kube-score

Kubernetes object analysis with recommendations for improved reliability and security. kube-score actively prevents downtime and bugs in your Kubernetes YAML and Charts. Static code analysis for Kubernetes.
https://kube-score.com
MIT License
2.65k stars 174 forks source link

Align `container-ephemeral-storage-request-and-limit` to `container-resources` #573

Closed ReuDa closed 6 months ago

ReuDa commented 6 months ago

The container-resources check adds comments for missing requests even if limits are missing.

The container-ephemeral-storage-request-and-limit check omits the request check comment if a limit is missing.

This PR will add a comment for both issues (limit and request) if both checks apply.

zegl commented 6 months ago

Thanks! This looks sane. :)