search

zehome / MLVPN

Multi-link VPN (ADSL/SDSL/xDSL/Network aggregation / bonding)
http://www.mlvpn.fr/
BSD 2-Clause "Simplified" License
521 stars 129 forks source link

Tunnels sections: Add DISABLE option #116

Closed lars18th closed 4 years ago

lars18th commented 5 years ago

Hi,

To do some tests it will be desirable to have the option to disable a channel in the configuration file:

[dsl1]
disable = 1
bindhost = "0.0.0.0"
bindport = 5080

So using a simple '#' at start, or changing to '= 0', it will be possible to enable/disable this tunnel.

You agree?

zehome commented 5 years ago

What is the benefit over commenting this tunnel + signaling (HUP) the daemon to remove/add the tunnel ?

lars18th commented 5 years ago

Hi @zehome ,

What is the benefit over commenting this tunnel ?

The benefit is changing only one character in the configuration file!

Imagine this scenario: 3 or more tunnels. You are adjusting one to one. So you need to "disable" various and check only one. Then you change to another, etc. But at time this implies to "comment" all lines of the tunnel like:

#[dsl1]
#bindhost = "0.0.0.0"
#bindport = 5080
#
# ...
#

A lot of work for a lot of lines. But you can do more easy changing only one chracter:

[dsl1]
disable = 0
bindhost = "0.0.0.0"
bindport = 5080
...

with 

[dsl1]
disable = 1
bindhost = "0.0.0.0"
bindport = 5080
...

I feel it more useable!

zehome commented 4 years ago

I'm sorry I won't implement such feature.